Add sepolia #2639
Merged
Add sepolia #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
approved these changes
Sep 13, 2022
| @@ -15,4 +15,5 @@ | |||
| 3: "ropsten", | |||
| 4: "rinkeby", | |||
| 5: "goerli", | |||
| 11155111: "sepolia", | |||
There was a problem hiding this comment.
Since this list is fairly small and we removed Kovan, it would be nice to update this exception message to include 11155111 (sepolia) as well:
web3.py/ethpm/validation/uri.py
Lines 105 to 107 in 845bce4
kclowes
added a commit
to kclowes/web3.py
that referenced
this pull request
Sep 14, 2022
* Add Sepolia testnet * Add Sepolia to ethpm validation error message
kclowes
added a commit
to kclowes/web3.py
that referenced
this pull request
Sep 14, 2022
* Add Sepolia testnet * Add Sepolia to ethpm validation error message
kclowes
added a commit
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Sepolia is a new testnet that should be added to web3's auto providers.
Related to Issue #2627
How was it fixed?
Added it!
Todo:
Cute Animal Picture